[Bug 1214357] Review Request: dist-git - Package source version control system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1214357



--- Comment #2 from Adam Samalik <asamalik@xxxxxxxxxx> ---
Thank you for the feedback. I have fixed all the issues and described them
below.
Spec URL: https://asamalik.fedorapeople.org/dist-git/dist-git.spec
SRPM URL:
https://asamalik.fedorapeople.org/dist-git/dist-git-0.8-1.fc21.src.rpm


Changes in %files section:
 - %config(noreplace)     %{_sysconfdir}/httpd/conf.d/ssl.conf.example
 + %config                %{_sysconfdir}/httpd/conf.d/ssl.conf.example

 - %config                %{_unitdir}/dist-git@.service
 + %{_unitdir}/dist-git@.service

 - %config                %{_unitdir}/dist-git.socket
 + %{_unitdir}/dist-git.socket

/var/lib/dist-git/gitolite/hooks/common is not listed twice anymore

All directories are owned by the package. Fixed for:
     /var/lib/dist-git/git, /usr/share
     /dist-git, /var/lib/dist-git, /var/lib/dist-git/gitolite/local, /var/lib
     /dist-git/gitolite, /var/lib/dist-git/cache, /etc/cron.d, /var/lib/dist-
     git/web, /etc/httpd/conf.d/dist-git, /var/lib/dist-git/cache/lookaside,
     /etc/cron.d/dist-git, /etc/dist-git

New files: COPYING ,LICENSE

> dist-git.noarch: W: dangling-symlink /var/lib/dist-git/git/.gitolite /var/lib/dist-git/gitolite
That's because I wanted to store gitolite files on one place as they contain
some git hooks and generated gitolite configuration. Scrips uses the original
path "/var/lib/dist-git/gitolite". The gitolite itself, however, expects this
directory under ~/.gitolite. It is also following the original design of
dist-git.

>dist-git.noarch: E: zero-length /var/lib/dist-git/gitolite/hooks/common/update
> dist-git.noarch: E: script-without-shebang /var/lib/dist-git/gitolite/hooks/common/update
Gitolite, for some reason, needs this file created in advance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]