https://bugzilla.redhat.com/show_bug.cgi?id=1214357 --- Comment #1 from Miroslav Suchý <msuchy@xxxxxxxxxx> --- > %config(noreplace) %{_sysconfdir}/httpd/conf.d/ssl.conf.example I would either leave out (noreplace) or I would put it in %doc directory (and remove %config completly). > %config %{_unitdir}/dist-git@.service > %config %{_unitdir}/dist-git.socket This should not be config at all. > /var/lib/dist-git/gitolite/hooks/common is listed twice. Because %attr (770, -, packager) %{_sharedstatedir}/dist-git/gitolite/hooks include this dir and *everything* below. So either put there %dir or remove that subdirectory [!]: Package must own all directories that it creates. Note: Directories without known owners: /var/lib/dist-git/git, /usr/share /dist-git, /var/lib/dist-git, /var/lib/dist-git/gitolite/local, /var/lib /dist-git/gitolite, /var/lib/dist-git/cache, /etc/cron.d, /var/lib/dist- git/web, /etc/httpd/conf.d/dist-git, /var/lib/dist-git/cache/lookaside, /etc/cron.d/dist-git, /etc/dist-git > dist-git.noarch: W: dangling-symlink /var/lib/dist-git/git/.gitolite /var/lib/dist-git/gitolite >dist-git.noarch: E: zero-length /var/lib/dist-git/gitolite/hooks/common/update > dist-git.noarch: E: script-without-shebang /var/lib/dist-git/gitolite/hooks/common/update > dist-git.noarch: W: no-documentation Since you are upstream, can you put there COPYING file where you would state which files are under which license and LICENSE files with all licenses used? And mark those files as %license Additionaly provided README you have in github as %doc would be nice too. Is this intentional? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review