Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mrxvt - Multi-tabbed terminal emulator. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=223422 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-05-22 12:28 EST ------- Well, I saw your spec file and actually there are many points to be fixed. (In reply to comment #12) > I'm not comfortable recommending these > changes to the maintainer without specific reasons; I don't see the reason for now why upstream should change directory tree of installation... For me every files are installed into where Fedora rpm packaging expects *when I compiled mrxvt correctly*. For this (mrxvt) it is actually due to the rpm packaging issue that files are not installed into the correct directories. So, first check the following wiki page first: http://fedoraproject.org/wiki/Packaging/Guidelines http://fedoraproject.org/wiki/Packaging/ReviewGuidelines http://fedoraproject.org/wiki/Packaging/NamingGuidelines and follow fedora rpm packaging way. And you can start from the spec file which already exists in Fedora, for example: http://cvs.fedora.redhat.com/viewcvs/*checkout*/devel/xterm/xterm.spec?root=core -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review