[Bug 1210941] Review Request: isrcsubmit - Script to submit ISRCs from disc to MusicBrainz

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1210941



--- Comment #4 from Ville Skyttä <ville.skytta@xxxxxx> ---
(In reply to Alexander Ploumistos from comment #3)
> Do you think that test_isrcsubmit.py could be covered by GPLv3+ or does it
> need another license (Public Domain or CC0)? I find upstream's wording a bit
> confusing.

I personally think this is a moot issue as we're not distributing
test_isrcsubmit.py as part of the binary packages nor does it contribute the
binary package contents in any way.

> If that is true, do you know if there is a "proper" way of
> dealing with it, e.g. renaming the one or the other? I couldn't find
> something relevant in the packaging guidelines.

I don't know if it's in the guidelines, but to me the proper way is to follow
upstream, and if someone's interested enough, ask upstream to drop the *.py
suffix from the executable as it becomes an issue if the script is sometimes
implemented in something else besides python. I don't personally care that
much.

> > "rm -rf $RPM_BUILD_ROOT" in %install is not a matter of distro version but
> > whether redhat-rpm-config is installed or not.
> 
> Could you please elaborate on that a bit

Not sure if there's actual documentation about it anywhere, but you can compare
the output of "rpm -E %__spec_install_pre" with and without redhat-rpm-config
installed on the distro version of your choice. See also (at least on F-20):
$ grep -A 4 __spec_install_pre /usr/lib/rpm/redhat/macros

> Is it possible to build rpms and not have redhat-rpm-config installed?

It certainly is. Note that the dependency that pulls in redhat-rpm-config in
rpm-build on recent Fedora versions is on system-rpm-config, not
redhat-rpm-config in particular (r-r-c just provides it, but it can be
satisfied by another package providing it). And some active distributions don't
even have that dependency, such as CentOS/RHEL/EPEL 6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]