[Bug 1210941] Review Request: isrcsubmit - Script to submit ISRCs from disc to MusicBrainz

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1210941



--- Comment #3 from Alexander Ploumistos <alex.ploumistos@xxxxxxxxx> ---
(In reply to Ville Skyttä from comment #2)
> * Sun Apr 19 2015 Ville Skyttä <ville.skytta@xxxxxx> - 2.0.0-2
> - Add man page, fix and run test suite (#1210941)

Do you think that test_isrcsubmit.py could be covered by GPLv3+ or does it need
another license (Public Domain or CC0)? I find upstream's wording a bit
confusing.

Although the man page is now in its proper place, rpmlint still complains. Is
it because the binary is named "isrcsubmit.py" while the man page is for
"isrcsubmit"? If that is true, do you know if there is a "proper" way of
dealing with it, e.g. renaming the one or the other? I couldn't find something
relevant in the packaging guidelines.

> The "False is not True" messages are actually just the tracebacks of the
> same previously failed CD insertion requiring checks, not any other ones.
> Anyway the test suite is fixed and run now.

Very nicely done.

> "rm -rf $RPM_BUILD_ROOT" in %install is not a matter of distro version but
> whether redhat-rpm-config is installed or not.

Could you please elaborate on that a bit, or point me to pertinent
documentation? I have no experience building on rhel or anything older than
F17. On my F21 system, repoquery --whatrequires redhat-rpm-config yields:

fedora-gnat-project-common-0:3.8-2.fc21.noarch
fedora-packager-0:0.5.10.4-2.fc21.noarch
fedora-packager-0:0.5.10.5-1.fc21.noarch
fedpkg-0:1.19-1.fc21.noarch
ghc-rpm-macros-0:1.2.16-1.fc21.x86_64
ghc-rpm-macros-0:1.2.19-1.fc21.x86_64
kernel-rpm-macros-0:26-1.fc21.noarch
kernel-rpm-macros-0:27-1.fc21.noarch
koji-builder-0:1.9.0-8.fc21.noarch
koji-builder-0:1.9.0-10.fc21.gitcd45e886.noarch
nodejs-packaging-0:7-2.fc21.noarch
pyrpkg-0:1.28-1.fc21.noarch
rpm-build-0:4.12.0.1-3.fc21.x86_64
rpm-build-0:4.12.0.1-5.fc21.x86_64
scl-utils-build-0:20140815-1.fc21.x86_64
scl-utils-build-1:2.0.1-2.fc21.x86_64
varnish-0:4.0.1-2.fc21.x86_64
varnish-0:4.0.3-3.fc21.x86_64

Is it possible to build rpms and not have redhat-rpm-config installed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]