[Bug 1213065] Review Request: hexer - ncurses-based binary editor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1213065



--- Comment #4 from Alex Kashchenko <mail@xxxxxxxxxxxxx> ---
Addressed comments 1, 2 and 3 (please remove "_v1" postfix after download):

Spec URL: https://bitbucket.org/akasko/share/downloads/hexer.spec_v1
SRPM URL:
https://bitbucket.org/akasko/share/downloads/hexer-0.1.8-1.fc23.src.rpm_v1

Diff between v0 and v1 specs:
https://bitbucket.org/akasko/share/downloads/v1_spec.diff


Comment 1:

 - removed upstream CHANGES link because this link
(http://devel.ringlet.net/editors/hexer/CHANGES) is not up to date, and while
up to date link exists in VSC
(https://www.gitorious.org/hexer/hexer/source/ed78162928ba92dc455e5bf1a3d05914bd993bae:CHANGES),
it is going to become unavailable soon after gitorius.org shutdown
 - moved patch description next to Patch0 entry as a comment
 - added the comment about patch upstreaming

Comment 2:

 - removed superfluous space in changelog

Comment 3:

 - removed rm -rf %{buildroot} entry


RPMLint output:

    rpmlint hexer-0.1.8-1.fc23.src.rpm 
    1 packages and 0 specfiles checked; 0 errors, 0 warnings.
    rpmlint hexer-0.1.8-1.fc23.x86_64.rpm
    1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]