https://bugzilla.redhat.com/show_bug.cgi?id=1210754 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- TODO: Please note there has already been a `json' package in Fedora (bug #495801). The name of this package is not very inventive and it can lead to confusions. Please consider more designating name. URL and Source0 are usable. Ok. Source archive is original (SHA-256: e12befc18961eb3eb8c0fe3aaa27ea34e073af7ae331c8b99360d8ba0c291cee). Ok. TODO: Use the github syntax for computing shorttag recommended by guidelines. The recommended code does not depend on coreutils. The version and release conform to git snapshot guidelines. Ok. Summary verified from README.md. Ok. Description is good. Ok. License verified from test/unit.cpp, src/json.hpp.re2c, src/json.hpp, README.md, LICENSE.MIT. Ok. TODO: Document Boost license (test/catch.hpp) in a spec file comment. TODO: I recommend not creating non-upstream pkg-config module. Such distribution-specific extensions give to developers an opportunity to write non-portable code. TODO: The src/json.hpp is generated file. Regenerate it from src/json.hpp.re2c. TODO: Run the tests (make && ./json_unit). The header-only library is packaged properly. Ok. $ rpmlint json.spec ../SRPMS/json-0-1.20150410git.d7d0509.fc23.src.rpm ../RPMS/x86_64/json-* json.spec:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 1) json.src: W: name-repeated-in-summary C JSON json.src: W: spelling-error %description -l en_US nlohmann -> Eichmann json.src:24: W: mixed-use-of-spaces-and-tabs (spaces: line 24, tab: line 1) json.x86_64: W: name-repeated-in-summary C JSON json.x86_64: W: spelling-error %description -l en_US nlohmann -> Eichmann json.x86_64: E: no-binary json-debuginfo.x86_64: E: empty-debuginfo-package json-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 1 specfiles checked; 2 errors, 7 warnings. TODO: Normalize spaces in the spec file. FIX: Disable generating debuginfo package (%global debug_package %{nil}). $ rpm -q -lv -p ../RPMS/x86_64/json-0-1.20150410git.d7d0509.fc23.x86_64.rpm drwxr-xr-x 2 root root 0 Apr 14 09:38 /usr/share/doc/json -rw-r--r-- 1 root root 15911 Apr 9 19:21 /usr/share/doc/json/README.md drwxr-xr-x 2 root root 0 Apr 14 09:38 /usr/share/licenses/json -rw-r--r-- 1 root root 1148 Apr 9 19:21 /usr/share/licenses/json/LICENSE.MIT $ rpm -q -lv -p ../RPMS/x86_64/json-devel-0-1.20150410git.d7d0509.fc23.x86_64.rpm |less -rw-r--r-- 1 root root 141967 Apr 9 19:21 /usr/include/json.hpp -rw-r--r-- 1 root root 219 Apr 14 09:38 /usr/lib64/pkgconfig/json.pc drwxr-xr-x 2 root root 0 Apr 14 09:38 /usr/share/doc/json-devel drwxr-xr-x 2 root root 0 Apr 14 09:38 /usr/share/doc/json-devel/html -rw-r--r-- 1 root root 9822 Apr 14 09:38 /usr/share/doc/json-devel/html/annotated.html [...] File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/json-0-1.20150410git.d7d0509.fc23.x86_64.rpm | sort -f | uniq -c 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 $ rpm -q --requires -p ../RPMS/x86_64/json-devel-0-1.20150410git.d7d0509.fc23.x86_64.rpm | sort -f | uniq -c 1 /usr/bin/pkg-config 1 json = 0-1.20150410git.d7d0509.fc23 1 pkgconfig 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Run-require `libstdc++-devel' by json-devel because /usr/include/json.hpp includes its header files. $ rpm -q --provides -p ../RPMS/x86_64/json-0-1.20150410git.d7d0509.fc23.x86_64.rpm | sort -f | uniq -c 1 json = 0-1.20150410git.d7d0509.fc23 1 json(x86-64) = 0-1.20150410git.d7d0509.fc23 $ rpm -q --provides -p ../RPMS/x86_64/json-devel-0-1.20150410git.d7d0509.fc23.x86_64.rpm | sort -f | uniq -c 1 json-devel = 0-1.20150410git.d7d0509.fc23 1 json-devel(x86-64) = 0-1.20150410git.d7d0509.fc23 1 json-static = 0-1.20150410git.d7d0509.fc23 1 pkgconfig(json) = 0-1.20150410git.d7d0509.fc23 Binary provides are Ok. Package build in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9474845). Ok. Otherwise the package is in line with Fedora packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide updated spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review