[Bug 1193878] Review Request: qmasterpassword - Stateless Master Password Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1193878



--- Comment #7 from Beat Küng <beat-kueng@xxxxxxx> ---
(In reply to Sinny Kumari from comment #6)
> (In reply to Beat Küng from comment #5)
> > Updated the spec file.
> > 
> > > > Requires:       qt5-qtbase >= 5.2.0
> > > 
> > > https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
> > 
> > I added a comment about the Qt version requirement.
> 
> Explicit require is not needed to specify in a spec file. It is left to be
> handled by rpmbuild to automatically add dependencies on library SONAMEs.
> Try to remove
>  Requires:       qt5-qtbase >= 5.2.0
> 
> and then rebuild package and then install it on system/test box and see if
> right dependency of qt5-base is getting pulled or not.

I tried to remove the line and rpmbuild adds the following dependencies:
libQt5Core.so.5()(64bit)
libQt5DBus.so.5()(64bit)
libQt5Gui.so.5()(64bit)
libQt5Widgets.so.5()(64bit)
[...]

which resolves to qt5-qtbase. The thing is if someone has qt5-base 5.0
installed, these deps are fulfilled, but the program actually uses
functionality that was only introduced in Qt 5.2. So I wanted to make sure this
is satisfied as well with
Requires:       qt5-qtbase >= 5.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]