Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: haproxy - TCP/HTTP reverse proxy for high availability environments https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233775 ------- Additional Comments From kevin@xxxxxxxxx 2007-05-21 22:48 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. See below - License(GPL) See below - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 45a66691aa3b22996862e3e5bac4289c haproxy-1.2.17.tar.gz 45a66691aa3b22996862e3e5bac4289c haproxy-1.2.17.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. You might ask upstream to include a copy of the GPL and the other odd license? Not a blocker. 2. What parts of the code are under the odd MIT-like O'Reilly license? It might be good to list them. Also, I can't find mention of this license in the code anywhere. Where is it stated? 3. rpmlint says: E: haproxy non-standard-uid /var/lib/haproxy haproxy E: haproxy non-standard-gid /var/lib/haproxy haproxy These can be ignored. Not a blocker. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review