https://bugzilla.redhat.com/show_bug.cgi?id=1203105 --- Comment #16 from Graeme Gillies <ggillies@xxxxxxxxxx> --- (In reply to Ken Dreyer from comment #15) > Lon's the official reviewer so I'll let him chime in any time :) > > In the meantime, you could move these alterations up to the %prep stage: > > sed -i /effin_utf8/d Gemfile > sed -i /effin_utf8/d spec/spec_helper.rb > sed -e "/require 'bundler\/setup'/d" -i spec/spec_helper.rb Done > > and perhaps add a comment explaining why effin_utf8 is not required so it's > clear to other developers why this change is present. Done > > I think README.md should be in the main package. Yeah that makes sense, not sure why I had it in -doc in the first place > > Also, this is just my personal opinion, other Ruby packagers may differ: a > lot of the other files that are currently in the -doc subpackage should just > be %exclude'd. I have a hard time picturing why ordinary users would want to > install any of the following files: > > %{gem_instdir}/spec > %{gem_instdir}/benchmarks > %{gem_instdir}/profiling > %{gem_instdir}/generate.rb > %{gem_instdir}/codegen > %{gem_instdir}/Rakefile > > They just bloat Fedora's yum filelists metadata and I tend to simply remove > all of these during %prep. I definitely agree, I was just following the example from the packaging guidelines page https://fedoraproject.org/wiki/Packaging:Ruby and also looking at other packages to see what they did. However, reading the guidelines again I noticed the big box stating "Do not ship tests" so I have removed them. Seems that page could use a lot of cleaning up (remove inconsistencies and some updates to include what to do with things like Rakefiles etc). New package http://ggillies.fedorapeople.org//rubygem-amq-protocol.spec http://ggillies.fedorapeople.org//rubygem-amq-protocol-1.9.2-3.fc21.src.rpm Regards, Graeme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review