[Bug 1203105] Review Request: rubygem-amq-protocol - AMQP 0.9.1 encoder & decoder

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1203105



--- Comment #15 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
Lon's the official reviewer so I'll let him chime in any time :)

In the meantime, you could move these alterations up to the %prep stage:

sed -i /effin_utf8/d Gemfile
sed -i /effin_utf8/d spec/spec_helper.rb
sed -e "/require 'bundler\/setup'/d" -i spec/spec_helper.rb

and perhaps add a comment explaining why effin_utf8 is not required so it's
clear to other developers why this change is present.

I think README.md should be in the main package.

Also, this is just my personal opinion, other Ruby packagers may differ: a lot
of the other files that are currently in the -doc subpackage should just be
%exclude'd. I have a hard time picturing why ordinary users would want to
install any of the following files:

%{gem_instdir}/spec
%{gem_instdir}/benchmarks
%{gem_instdir}/profiling
%{gem_instdir}/generate.rb
%{gem_instdir}/codegen
%{gem_instdir}/Rakefile

They just bloat Fedora's yum filelists metadata and I tend to simply remove all
of these during %prep.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]