[Bug 1203476] Review Request: sslh - Applicative protocol(SSL/SSH) multiplexer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1203476

Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tcallawa@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |tcallawa@xxxxxxxxxx



--- Comment #11 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> ---
One obvious item that needs to be fixed is that you need to compile with
optflags. The simplest way to do this is to override CFLAGS at your make
invocation:

make %{?_smp_mflags} USELIBWRAP=1 USELIBCAP=1 CFLAGS="%{optflags}" %{name}

Also, your spacing is odd at the top. Either use tabs or spaces, and try to
make sure it all lines up cleanly. RPM doesn't care, but every packager after
you will thank you. :)

Fix those two items and I'll finish the review here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]