https://bugzilla.redhat.com/show_bug.cgi?id=1197505 --- Comment #2 from Ross Lagerwall <rosslagerwall@xxxxxxxxx> --- Thanks for the review! (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #1) > > Name: libnfs > > Group: Development/Libraries > > Base library packages have been in group "System Environment/Libraries" for > many years. The group "Development/Libraries" is for -devel packages, i.e. > the separate build-time packages. > > Nowadays, the Group tag is optional: > https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag OK, removed. > > > > License: LGPLv2+ > > https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text > > Upstream ought to include the LGPL terms, especially since the documentation > (in file COPYING) refers to both the LGPL and the GPL v3 for the examples. OK. I've set the main package's license to LGPLv2+ and BSD since this is more accurate and also included COPYING in the package. I've sent a pull request so that upstream includes the license terms: https://github.com/sahlberg/libnfs/pull/114 > > > > rm -rf %{buildroot}%{_bindir} > > rm -rf %{buildroot}%{_mandir} > > Deleting files without explanation is not good style. What's the reason why > you delete the files? OK. It now builds a libnfs-utils package that includes these files. > > > > %files devel > > %{_libdir}/libnfs.so > > %{_includedir}/nfsc/* > > Package /usr/include/nfsc is not included. > > https://fedoraproject.org/wiki/Packaging: > Guidelines#File_and_Directory_Ownership > https://fedoraproject.org/wiki/Packaging:UnownedDirectories Fixed. > > > > Link to koji builds: > > Consider pointing the fedora-review tool at review tickets like this. It can > be very helpful for new packagers: fedora-review -b 1197505 Thanks for pointing this out. Updated files: Spec URL: https://rossl.org/junk/v2/libnfs.spec SRPM URL: https://rossl.org/junk/v2/libnfs-1.9.7-2.fc21.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9359835 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review