https://bugzilla.redhat.com/show_bug.cgi?id=1197505 --- Comment #1 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> --- > Name: libnfs > Group: Development/Libraries Base library packages have been in group "System Environment/Libraries" for many years. The group "Development/Libraries" is for -devel packages, i.e. the separate build-time packages. Nowadays, the Group tag is optional: https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag > License: LGPLv2+ https://fedoraproject.org/wiki/Packaging:Guidelines#Licensing https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Upstream ought to include the LGPL terms, especially since the documentation (in file COPYING) refers to both the LGPL and the GPL v3 for the examples. > rm -rf %{buildroot}%{_bindir} > rm -rf %{buildroot}%{_mandir} Deleting files without explanation is not good style. What's the reason why you delete the files? > %files devel > %{_libdir}/libnfs.so > %{_includedir}/nfsc/* Package /usr/include/nfsc is not included. https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership https://fedoraproject.org/wiki/Packaging:UnownedDirectories > Link to koji builds: Consider pointing the fedora-review tool at review tickets like this. It can be very helpful for new packagers: fedora-review -b 1197505 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review