https://bugzilla.redhat.com/show_bug.cgi?id=1202431 --- Comment #5 from Milan Crha <mcrha@xxxxxxxxxx> --- (In reply to David Woodhouse from comment #2) > > Requires: pkgconfig(glib-2.0) > > Requires: pkgconfig(gobject-2.0) > > Requires: pkgconfig(gobject-introspection-1.0) > > Requires: pkgconfig(libxml-2.0) > > Requires: pkgconfig(libical) >= %{libical_version} > > Two of those are redundant because they're in libical-glib.pc and thus RPM > picks them up automatically. > > The other three are suspicious precisely because they're *not* in > libical-glib.pc Right, the gobject-introspection-1.0 and libxml-2.0 are required for build only, not for the runtime of the -devel subpackage. My fault. (In reply to David Woodhouse from comment #4) > > ===== MUST items ===== > > > > [ ]: Package must own all directories that it creates. > > Note: Directories without known owners: /usr/share/gtk-doc, /usr/share > > /gtk-doc/html, /usr/lib64/girepository-1.0 > > Do we need to require the corresponding packages (or directories)? I do not know how to properly address them. The girepository is owned by gobject-introspection [1] and the gtk-doc folders, hmm, they do not seem to be owned by anything, nether the gtk-doc package [2]. I checked glib2 spec and they do not require gtk-doc for the -doc subpackage. I would also expect that the rpm will pick necessary packages on demand, how it does that for other dependencies. [1] http://pkgs.fedoraproject.org/cgit/gobject-introspection.git/tree/gobject-introspection.spec [2] http://pkgs.fedoraproject.org/cgit/gtk-doc.git/tree/gtk-doc.spec > > ===== SHOULD items ===== > > > > [ ]: Spec use %global instead of %define unless justified. > > Note: %define requiring justification: %{!?with_docs: %define with_docs > > 1}, %define gtkdoc_flags --enable-gtk-doc, %define gtkdoc_flags > > --disable-gtk-doc Fixed. So the only opened issue is for the directory ownership for those not really owned by the libical-glib. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review