https://bugzilla.redhat.com/show_bug.cgi?id=1202431 David Woodhouse <dwmw2@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #4 from David Woodhouse <dwmw2@xxxxxxxxxxxxx> --- Items from the 'fedora-review' output which need manual checking and aren't *obviously* OK... > ===== MUST items ===== > > [ ]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/share/gtk-doc, /usr/share > /gtk-doc/html, /usr/lib64/girepository-1.0 Do we need to require the corresponding packages (or directories)? > [ ]: Requires correct, justified where necessary. See comment 2, > ===== SHOULD items ===== > > [ ]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %{!?with_docs: %define with_docs > 1}, %define gtkdoc_flags --enable-gtk-doc, %define gtkdoc_flags > --disable-gtk-doc With those addressed, I think I'm happy. I'll go ahead and set the fedora-review flag to + in anticipation... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review