https://bugzilla.redhat.com/show_bug.cgi?id=1202063 --- Comment #12 from Antti Järvinen <antti.jarvinen@xxxxxxxxxxx> --- Spec URL: http://katiska.org/classified_ads/srpm/classified-ads.spec SRPM URL: http://katiska.org/classified_ads/srpm/classified-ads-0.05-1.fc21.src.rpm Ok, fedora-review was very helpful, issues raised and fixed are these: - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /tmp/review-1202063/1202063 -classified-ads/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL -> actual release (0.05) now built - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 -> gcc-c++ dependency gone - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros -> %{buildroot} selected - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find LICENSE in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text -> The binary rpm does install /usr/share/licenses/classified-ads/LICENSE and in spec that is done using %license keyword - is the tool failing to detect that or what? No change done due to this reported issue. - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. -> validation added [!]: Uses parallel make %{?_smp_mflags} macro. -> used %{?_smp_mflags} in make Note: Directories without known owners: /usr/share/app-install, /usr/share/app-install/icons, /usr/share/classified-ads -> now included directories in spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review