https://bugzilla.redhat.com/show_bug.cgi?id=1200389 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #17 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- caml-crush.spec.old 2015-03-23 09:54:24.000000000 +0100 +++ caml-crush.spec 2015-03-25 13:58:22.000000000 +0100 @@ -26,7 +26,7 @@ Patch3: caml-crush-better-msgs.patch Patch4: caml-crush-honor-CFLAGS.patch -Requires(pre): shadow-utils +Requires(pre): shadow-utils BuildRequires: autoconf BuildRequires: ocaml >= 4.00 BuildRequires: ocaml-findlib-devel @@ -54,6 +54,7 @@ Requires(preun): systemd Requires(postun): systemd +%global __provides_exclude_from ^%{_libdir}/pkcs11/.*\\.so$ %description This software implements a PKCS#11 proxy as well as a PKCS#11 filter with @@ -121,8 +122,6 @@ install -p -m 644 %{SOURCE8} %{buildroot}%{_sharedstatedir}/pkcs11proxyd/.config/pkcs11/ install -p -m 644 %{SOURCE9} %{buildroot}%{_sharedstatedir}/pkcs11proxyd/.config/pkcs11/modules -%global __provides_filter_from ^%{_libdir}/pkcs11/.*\\.so$ - %files %doc README.md ISSUES.md %license LICENSE.txt > FIX: There is still src/bindings-pkcs11/pkcs11f.h with the same RSA license. > The file is not used. Remove it from the archive too. The files has been removed. Ok. Source archive (SHA-256:08d647041727d2f1d2d37b69a4d43eae2d76bcca0803dc2e9199676172971ea8) is Ok. > TODO: Move the macro definition right before %description section. It's the > common place where to write the filters. Ok. > > FIX: Your change did not removed the provides. The correct macro is name is > > `__provides_exclude_from'. See > > <https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Preventing_files.2Fdirectories_from_being_scanned_for_deps_.28pre-scan_filtering.29>. > I used from the example in the same guidelines. Most probably a bug in the > example. > https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Pidgin_plugin_package Yes, the example is wrong. I request a fix <https://fedorahosted.org/fpc/ticket/519>. +%global __provides_exclude_from ^%{_libdir}/pkcs11/.*\\.so$ [...] -%global __provides_filter_from ^%{_libdir}/pkcs11/.*\\.so$ $ rpm -q --provides -p ../RPMS/x86_64/caml-crush-1.0.4-4.fc23.x86_64.rpm | sort -f | uniq -c 1 caml-crush = 1.0.4-4.fc23 1 caml-crush(x86-64) = 1.0.4-4.fc23 1 config(caml-crush) = 1.0.4-4.fc23 $ rpm -q --provides -p ../RPMS/x86_64/caml-crush-softhsm-1.0.4-4.fc23.x86_64.rpm | sort -f | uniq -c 1 caml-crush-softhsm = 1.0.4-4.fc23 1 caml-crush-softhsm(x86-64) = 1.0.4-4.fc23 Binary provides are Ok. > TODO: Please append the expression to possible current %__provides_exclude_from > value like this: No addressed. Ok. > TODO: normalize the white spaces. $ rpmlint caml-crush.spec ../SRPMS/caml-crush-1.0.4-4.fc23.src.rpm ../RPMS/x86_64/caml-crush-* caml-crush.spec:46: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 46) caml-crush.spec: W: invalid-url Source0: v1.0.4-hobbled.tar.gz caml-crush.src: W: strange-permission pkcs11proxyd-init 0755L caml-crush.src:46: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 46) caml-crush.src: W: invalid-url Source0: v1.0.4-hobbled.tar.gz caml-crush.x86_64: W: no-manual-page-for-binary pkcs11proxyd caml-crush-softhsm.x86_64: W: no-documentation caml-crush-softhsm.x86_64: W: non-standard-uid /var/lib/pkcs11proxyd/softhsm.conf pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-gid /var/lib/pkcs11proxyd/softhsm.conf pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-uid /var/lib/pkcs11proxyd/.config/pkcs11 pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-gid /var/lib/pkcs11proxyd/.config/pkcs11 pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-uid /var/lib/pkcs11proxyd/.config/pkcs11/pkcs11.conf pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-gid /var/lib/pkcs11proxyd/.config/pkcs11/pkcs11.conf pkcs11proxyd caml-crush-softhsm.x86_64: W: non-conffile-in-etc /etc/pkcs11proxyd/filter-softhsm.conf caml-crush-softhsm.x86_64: W: non-standard-uid /var/lib/pkcs11proxyd/.config/pkcs11/modules/softhsm.module pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-gid /var/lib/pkcs11proxyd/.config/pkcs11/modules/softhsm.module pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-uid /var/lib/pkcs11proxyd/.config pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-gid /var/lib/pkcs11proxyd/.config pkcs11proxyd caml-crush-softhsm.x86_64: W: hidden-file-or-dir /var/lib/pkcs11proxyd/.config caml-crush-softhsm.x86_64: W: hidden-file-or-dir /var/lib/pkcs11proxyd/.config caml-crush-softhsm.x86_64: W: non-conffile-in-etc /etc/pkcs11proxyd/pkcs11proxyd-softhsm.conf caml-crush-softhsm.x86_64: W: non-standard-uid /var/lib/pkcs11proxyd pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-gid /var/lib/pkcs11proxyd pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-uid /var/lib/pkcs11proxyd/.config/pkcs11/modules pkcs11proxyd caml-crush-softhsm.x86_64: W: non-standard-gid /var/lib/pkcs11proxyd/.config/pkcs11/modules pkcs11proxyd caml-crush-softhsm.x86_64: W: no-manual-page-for-binary pkcs11proxyd-init 4 packages and 1 specfiles checked; 0 errors, 26 warnings. rpmlint is Ok. Package builds in F23 (http://koji.fedoraproject.org/koji/taskinfo?taskID=9321428). Ok. Package is in line with Fedora packaging guidelines. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review