https://bugzilla.redhat.com/show_bug.cgi?id=1200389 --- Comment #16 from Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> --- (In reply to Petr Pisar from comment #15) > FIX: There is still src/bindings-pkcs11/pkcs11f.h with the same RSA license. > The file is not used. Remove it from the archive too. Done > > FIX: So either it's a public library, or it's a private library. See > > <https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Private_Libraries> > > for the second case, and > > <https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Beware_of_Rpath> for the first case. > +%global __provides_filter_from ^%{_libdir}/pkcs11/.*\\.so$ > + I used from the example in the same guidelines. Most probably a bug in the example. https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Pidgin_plugin_package > TODO: Move the macro definition right before %description section. It's the > common place where to write the filters. > $ rpm -q --provides -p ../RPMS/x86_64/caml-crush-1.0.4-4.fc23.x86_64.rpm | > sort -f | uniq -c > 1 caml-crush = 1.0.4-4.fc23 > 1 caml-crush(x86-64) = 1.0.4-4.fc23 > 1 config(caml-crush) = 1.0.4-4.fc23 > 1 libp11client.so()(64bit) For some reason I don't see libp11client.so whether I add the filter or not. That's why I don't know whether the filter works or not. > TODO: Please append the expression to possible current > %__provides_exclude_from value like this: > > %global __provides_exclude_from > %{?__provides_exclude_from:%__provides_exclude_from|}^%{_libdir}/pkcs11/.*\\. > so$ > It could happen the the value had already been defined somewhere else (macro > files) and you could lose the old filter. I'm not sure whether the previous provides should be replicated, this is not mentioned in the guidelines, and while it seems logical what you suggest, I'd be reluctant to use it. Done. > TODO: normalize the white spaces. Done. Spec URL: http://people.redhat.com/nmavrogi/fedora/caml-crush.spec SRPM URL: http://people.redhat.com/nmavrogi/fedora/caml-crush-1.0.4-4.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review