https://bugzilla.redhat.com/show_bug.cgi?id=1201662 --- Comment #11 from Marek Skalický <mskalick@xxxxxxxxxx> --- (In reply to Jonathan Underwood from comment #9) > Still some rpmlint flagged issues: > > (1) > wiredtiger.src:66: W: rpm-buildroot-usage %build sed -i -r > "s|(\(PYTHON_INSTALL_ARG\))|\1 --no-compile --install-dir > %{buildroot}%{python_sitelib}|" lang/python/Makefile.am > $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it may > break short circuit builds. > > > This is because you're doing loads of stuff in %build that should be done in > %prep. All of this should be in %prep: I am not really sure about this. In all examples of RPM on fedora wiki, confingure is in %build (https://fedoraproject.org/wiki/How_to_create_an_RPM_package). I wrong understood this warning, so the first version was right: sed -i -r "s|(\(PYTHON_INSTALL_ARG\))|\1 --no-compile --install-dir %{buildroot}%{python_sitelib}|" lang/python/Makefile.am -> should be in %prep and later stuff needs to be in %build. So this warning is false, because with sed, I am not touching buildroot. I changed this and BUILDROOT is used with configure. I think this warning remains... > (3) > wiredtiger-python.x86_64: E: non-standard-executable-perm > /usr/lib/python2.7/site-packages/wiredtiger/_wiredtiger.so 0775L > A standard executable should have permission set to 0755. If you get this > message, it means that you have a wrong executable permissions in some files > included in your package. > > This is a compiled extension, and so should be under %{python_sitearch}, > rather than under %{python_sitelib}. The former is for compiled extension > modules, the latter for pure python (arch independent) modules. See: > > http://fedoraproject.org/wiki/Packaging:Python Fixed. Spec URL: https://mskalick.fedorapeople.org/wiredtiger/wiredtiger.spec SRPM URL: https://mskalick.fedorapeople.org/wiredtiger/wiredtiger-2.5.1-4.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review