https://bugzilla.redhat.com/show_bug.cgi?id=1201662 --- Comment #10 from Jonathan Underwood <jonathan.underwood@xxxxxxxxx> --- Also, small nits: (1) This: %files python %dir %{python_sitelib}/%{name} %{python_sitelib}/%{name}/* is redundant... simply: %files python %{python_sitelib}/%{name} would make the package own the directory and the files under it. Similarly for the java package. (Of course, in the python case, you'll be moving to using sitearch instead/as well). (2) For readability add a blank line before %package libs (3) For readability, break long lines with trailing "\", eg. %configure --disable-static \ --with-builtins=zlib,snappy \ --enable-python \ --enable-java JAR="%{java_home}/bin/jar" etc. (4) This weird white space is very unusual, reduces readability, and hinders others helping to maintain your package: mkdir %{buildroot}%{_libdir}/%{name} mv %{buildroot}%{_javadir}/%{name}-%{version}/lib* %{buildroot}%{_libdir}/%{name} rm %{buildroot}%{_libdir}/%{name}/lib*.so mkdir %{buildroot}%{_jnidir} mv %{buildroot}%{_javadir}/%{name}-%{version}/%{name}.jar %{buildroot}%{_jnidir}/ rmdir %{buildroot}%{_javadir}/%{name}-%{version} ... just have a single space separating the commands and their arguments. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review