[Bug 1199693] Review Request: pcp-pmda-cpp - C++ library for PCP PMDAs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1199693



--- Comment #16 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
* The -examples package now needs an explicit dependency on "pcp", because that
is the package that provides the /var/lib/pcp/pmdas directory.

The same bug affects the "pcp" packages: bug 1204467


> %package devel
> Requires: pcp-libs-devel

The explicit dependency on "pcp-libs-devel" would be safer (for the case when
linking with any of the pcp shared libs), if it were arch-specific:

  Requires: pcp-libs-devel%{?_isa}

That is, because -devel packages and their dependencies are multilib packages:
# yum list pcp-libs-devel|grep ^pcp
pcp-libs-devel.i686                     3.10.3-1.fc21                   
updates
pcp-libs-devel.x86_64                   3.10.3-1.fc21                   
updates


* It doesn't build with latest GCC 5 in Rawhide:

[...]
/builddir/build/BUILD/pcp-pmda-cpp-0.4.2/pcp-pmda-cpp-0.4.2/example/simple/../../include/pcp-cpp/pmda.hpp:
In member function 'virtual int pcp::pmda::on_store(pmResult*, pmdaExt*)':
/builddir/build/BUILD/pcp-pmda-cpp-0.4.2/pcp-pmda-cpp-0.4.2/example/simple/../../include/pcp-cpp/pmda.hpp:1135:38:
error: suggest parentheses around operand of '!' or change '&' to '&&' or '!'
to '~' [-Werror=parentheses]
                     if (!description.flags & pcp::storable_metric) {
                                      ^
In file included from
/builddir/build/BUILD/pcp-pmda-cpp-0.4.2/pcp-pmda-cpp-0.4.2/example/simple/simple.cpp:18:0:
/builddir/build/BUILD/pcp-pmda-cpp-0.4.2/pcp-pmda-cpp-0.4.2/example/simple/../../include/pcp-cpp/pmda.hpp:
In member function 'virtual int pcp::pmda::on_store(pmResult*, pmdaExt*)':
/builddir/build/BUILD/pcp-pmda-cpp-0.4.2/pcp-pmda-cpp-0.4.2/example/simple/../../include/pcp-cpp/pmda.hpp:1135:38:
error: suggest parentheses around operand of '!' or change '&' to '&&' or '!'
to '~' [-Werror=parentheses]
                     if (!description.flags & pcp::storable_metric) {
                                      ^
cc1plus: all warnings being treated as errors
[...]

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]