https://bugzilla.redhat.com/show_bug.cgi?id=1200389 Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(rjones@xxxxxxxxxx | |) --- Comment #6 from Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> --- Updated package: Spec URL: http://people.redhat.com/nmavrogi/fedora/caml-crush.spec SRPM URL: http://people.redhat.com/nmavrogi/fedora/caml-crush-1.0.4-3.fc21.src.rpm (In reply to Petr Pisar from comment #5) > URL is usable. Ok. > FIX: Source0 is invalid: Done. > FIX: Many Makefile.in files hard-code C compiler optimization level > (CFLAGS_OPT variable). Distribution's CCFLAGS should be respected. Done. > Just an orthogonal notice: Something is wrong with ocaml packages: > Installing build-time dependencies pulls in half of desktop packages (pango, > udisks2, libwayland-server, etc.). Either this spec file build-requires too > much, or the ocaml is doomed. I know debian has ocaml-nox to avoid these dependencies. Maybe Richard can provide some info here on whether we can optimize that. We would certainly not want to depend on X to bring pkcs11proxyd. > TODO: The patches are prefixed `ocaml-crush', while the package is called > `caml-crush'. Please rename the patches to start with `caml-crush-1.0.4'. Done. > FIX: Do not bundle filter.conf (Source1). Patch src/pkcs11proxyd/filter.conf > instead. The difference is 4 lines only. Not done. I do want to keep a fedora config file which I control. Upstream has deviated a lot in the git repository and I wouldn't like to be surprised by updates. > TODO: Use printf(1) instead of echo(1) in pkcs11proxyd-init. Handling escape > sequences is undefined by POSIX. Done. > TODO: Consider using <https://fedoraproject.org/wiki/Packaging:Tmpfiles.d> > instead of manual named socket handling by pkcs11proxyd-post. My use case was simpler. Used Umask instead. > TODO: Remove initial `a' from Summary. Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review