https://bugzilla.redhat.com/show_bug.cgi?id=1200389 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |ppisar@xxxxxxxxxx Flags| |fedora-review? --- Comment #5 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL is usable. Ok. FIX: Source0 is invalid: $ wget https://github.com/dlundquist/sniproxy/archive/v1.0.4.tar.gz --2015-03-18 10:51:50-- https://github.com/dlundquist/sniproxy/archive/v1.0.4.tar.gz Resolving github.com (github.com)... 192.30.252.130 Connecting to github.com (github.com)|192.30.252.130|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://codeload.github.com/dlundquist/sniproxy/tar.gz/v1.0.4 [following] --2015-03-18 10:51:50-- https://codeload.github.com/dlundquist/sniproxy/tar.gz/v1.0.4 Resolving codeload.github.com (codeload.github.com)... 192.30.252.147 Connecting to codeload.github.com (codeload.github.com)|192.30.252.147|:443... connected. HTTP request sent, awaiting response... 404 Not Found 2015-03-18 10:51:51 ERROR 404: Not Found. FIX: Many Makefile.in files hard-code C compiler optimization level (CFLAGS_OPT variable). Distribution's CCFLAGS should be respected. Just an orthogonal notice: Something is wrong with ocaml packages: Installing build-time dependencies pulls in half of desktop packages (pango, udisks2, libwayland-server, etc.). Either this spec file build-requires too much, or the ocaml is doomed. TODO: The patches are prefixed `ocaml-crush', while the package is called `caml-crush'. Please rename the patches to start with `caml-crush-1.0.4'. FIX: Do not bundle filter.conf (Source1). Patch src/pkcs11proxyd/filter.conf instead. The difference is 4 lines only. TODO: Use printf(1) instead of echo(1) in pkcs11proxyd-init. Handling escape sequences is undefined by POSIX. TODO: Consider using <https://fedoraproject.org/wiki/Packaging:Tmpfiles.d> instead of manual named socket handling by pkcs11proxyd-post. TODO: Remove initial `a' from Summary. I will continue with the review after you provide fixed package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review