https://bugzilla.redhat.com/show_bug.cgi?id=1202604 --- Comment #3 from Stephen Gallagher <sgallagh@xxxxxxxxxx> --- (In reply to Michael Schwendt (Fedora Packager Sponsors Group) from comment #2) > %py3dir is not to be used anymore since it stores files outside %_builddir > where they are not removed by rpmbuild: > > > https://fedoraproject.org/w/index. > php?title=PackagingDrafts%3APython&diff=403829&oldid=403815 > [ https://fedorahosted.org/fpc/ticket/435 ] > > OK, I will change that. I copied this bit from firewalld since it was my first time doing a dual-stack build. Thanks for the pointer. > > %build > > # Remove CFLAGS=... for noarch packages (unneeded) > > CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py build > > The comments raises questions. The package is "noarch", so the CFLAGS > definition is really not needed. > > Yeah, I generated the spec with rpmdev-newspec -t python and it included that. I can remove it. > > %files > > %doc > > An empty %doc line is a no-op and should be deleted. %doc is not a spec file > section like %build (an empty %build section could be deleted, too, but the > guidelines want it to be empty instead). > Right, as above this was generated by the newspec and I forgot to remove it. > Since you are upstream, consider this: > https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Yes, I remembered that just after cutting the 0.1 tarball. As code audit is revealing a couple minor issues, I'm going to cut a 0.2 tarball today with the license text in it. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review