[Bug 1202604] Review Request: python-sscg - Self-signed Certificate Generator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1202604



--- Comment #2 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
%py3dir is not to be used anymore since it stores files outside %_builddir
where they are not removed by rpmbuild:

 
https://fedoraproject.org/w/index.php?title=PackagingDrafts%3APython&diff=403829&oldid=403815
  [ https://fedorahosted.org/fpc/ticket/435 ]


> %build
> # Remove CFLAGS=... for noarch packages (unneeded)
> CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py build

The comments raises questions. The package is "noarch", so the CFLAGS
definition is really not needed.


> %files
> %doc

An empty %doc line is a no-op and should be deleted. %doc is not a spec file
section like %build (an empty %build section could be deleted, too, but the
guidelines want it to be empty instead).

Since you are upstream, consider this:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]