https://bugzilla.redhat.com/show_bug.cgi?id=1197471 Alec Leamas <leamas.alec@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady | --- Comment #13 from Alec Leamas <leamas.alec@xxxxxxxxx> --- (In reply to Mikolaj Izdebski from comment #8) > First, the main license in tonto-1.44/doc/LICENSE.txt file is not the > Artistic license described on Fedora wiki - License updated to the proper Artistic Clarified after talking to upstream. > 1. You should use %{version} in source URLs, this will make updating package > easier. Done, bending to your argument. Note that the GL has this as an explicit example of personal preferences, though. > 2. get-source1.sh should have "mktemp -d" instead of pure mktemp. mktemp > without -d creates regular file Not needed, it's the default behaviour (man mktemp....) > 3. %{name} should be used in the whole spec file, but especially in paths. > This is to minimize changes needed when the package is renamed (eg. when > introducing compat package or SCL-izing package) Done, once again bending to your arguments (my personal style so far has been to avoid macros for things not likely to change). > 4. desktop files should not use --vendor tag, see > http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage Done > 5. missing %license in javadoc subpackage Done I have a "file listed twice" problem I can't handle in any reasonable way :( New links: spec: https://leamas.fedorapeople.org/harctoolbox/tonto.spec srpm: https://leamas.fedorapeople.org/harctoolbox/tonto-1.44-5.fc21.src.rpm Package is ready after a really short upstream round-trip. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review