[Bug 1197947] Review Request: khard - An address book for the Linux console

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1197947



--- Comment #4 from Florian "der-flo" Lehner <dev@xxxxxxxxxxx> ---
Hi Ben!

> > [ ] Please append 
> >     #/%{name}-%{version}.tar.gz
> >     to your Source0 to get a propper named source.
> 
> I see no reason why this is necessary. %setup -n handles this just fine.

rpm will then use %{name}-%{version}.tar.gz as the tarball name. If you use
spectool -g khard.spec to download the tarball, it will rename the tarball for
you.
At the moment, you get v0.2.1.tar.gz which can be everything. It just makes it
easier to handle multiple packages and is not a blocker.


> > khard.noarch: E: non-executable-script
> > /usr/lib/python2.7/site-packages/davcontroller/davcontroller.py 0644L
> > /usr/bin/python
> 
> Patched locally and filed upstream:
> <https://github.com/scheibler/khard/issues/8>.

Your patch doesn't work well. Please take a look at:
https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries

Cheers,
 Florian

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]