https://bugzilla.redhat.com/show_bug.cgi?id=1197947 --- Comment #3 from Ben Boeckel <mathstuf@xxxxxxxxx> --- Thanks. (In reply to Florian "der-flo" Lehner from comment #2) > [ ] Package contains BR: python2-devel or python3-devel Fixed. > [ ] There is no version in your changelog Fixed. > [ ] Please append > #/%{name}-%{version}.tar.gz > to your Source0 to get a propper named source. I see no reason why this is necessary. %setup -n handles this just fine. > [ ] Some points from rpmlint: > khard.noarch: W: doc-file-dependency > /usr/share/doc/khard/twinkle-plugin/scripts/incoming_call_failed.py > /usr/bin/env > khard.noarch: W: doc-file-dependency > /usr/share/doc/khard/twinkle-plugin/scripts/incoming_call_ended.py > /usr/bin/env I'll just leave these out; twinkle isn't in Fedora anyways. > khard.noarch: E: non-executable-script > /usr/lib/python2.7/site-packages/davcontroller/davcontroller.py 0644L > /usr/bin/python Patched locally and filed upstream: <https://github.com/scheibler/khard/issues/8>. > khard.src: W: strange-permission v0.2.1.tar.gz 0640L > khard.src: W: strange-permission khard.spec 0640L My umask; no effect when built from infrastructure. Spec URL: http://mathstuf.fedorapeople.org//khard.spec SRPM URL: http://mathstuf.fedorapeople.org//khard-0.2.1-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review