https://bugzilla.redhat.com/show_bug.cgi?id=1195875 Peter Robinson <pbrobinson@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pbrobinson@gmail. | |com) | --- Comment #3 from Peter Robinson <pbrobinson@xxxxxxxxx> --- > Any reason for using %define tarfile %{name}-%{version}.tar.bz2 ? The only > time I see it is where it is defined. An oversight > Since you are using a couple directories (/usr/lib/udev/ and > /usr/lib/systemd) owned by systemd, you probably ought to require systemd > for completeness. Possibly, but it's also superfluous, and the binary is also usable without systemd. > In your %files section, you're explicitly using /usr/lib/ instead of > %{_libdir} It's a udev rule, all udev rules are explicitly in /usr/lib whether 32 or 64 bit so in this case the macro is not used. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review