[Bug 1195875] Review Request: ti-uim - Texas Instruments User Mode Init manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1195875

John Dulaney <jdulaney@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pbrobinson@xxxxxxxxx
              Flags|                            |needinfo?(pbrobinson@gmail.
                   |                            |com)



--- Comment #2 from John Dulaney <jdulaney@xxxxxxxxxxxxxxxxx> ---
Okay, a few things:

Any reason for using %define tarfile %{name}-%{version}.tar.bz2 ?  The only
time I see it is where it is defined.

Since you are using a couple directories (/usr/lib/udev/ and /usr/lib/systemd)
owned by systemd, you probably ought to require systemd for completeness.

In your %files section, you're explicitly using /usr/lib/ instead of %{_libdir}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]