[Bug 902086] Review request: Elasticsearch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=902086



--- Comment #131 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Issues:
- please reflow %description into paragraphs separated with empty lines. rpm -i
and other tools treat it as preformatted text and it looks a bit ugly right
now.

- In %files javadoc move NOTICE.txt to %license too.

- I don't understand the change with R:jpackage-utils, R:java-headless. You
mention #1194110 as the reason, but that bug was about missing dependency on
xmvn-resolve. mvn-resolve is not needed iiuc, so why not remove this?

- R:java-base64 >= 2.3.8-7 is also needed. BR is not enough.

(In reply to jiri vanek from comment #129)
> The user is never removed?
Yes. It's very hard to cleanly remove a user, because in principle you'd have
to search all of the filesystem for files owned by the user. So users are never
removed except by the admin.

- /var/lib/elasticsearch should be owned by elasticsearch. You need to add
%attr in the %files section. See
http://www.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html.

- When the daemon is started, is still listens on [::]:9200 and [::]:9300. The
daemon has to be fixed to not accept commands from the network in the default
configuration.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]