https://bugzilla.redhat.com/show_bug.cgi?id=1186503 --- Comment #13 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Mario Blättermann from comment #12) > > Some ignorable things: > > * False positive spelling errors > > * desktopfile-without-binary: we use xdg-open as a wrapper only > * no-manual-page-for-binary: not up to you to fix > accepted > But also important issues: > > Invalid appdata file: > $ appstream-util validate *.xml > openclonk.appdata.xml: FAILED: > • tag-invalid : <project_license> is not valid: SPDX ID 'GPLv2+' > unknown > > The license tag in this file is not conform to those licenses we use in spec > files. Have a look at the license shortcuts applicable here: > http://spdx.org/licenses/ > As far as I ca see, the license tag here has to be "GPL-2.0+ and > BSD-2-Clause and ISC and CC-BY-SA-3.0". But the correct version of the BSD > and CreativeCommon licenses still needs to be investigated. > yes indeed > A lot of spurious-executable-perm warnings. Remove the executable bit from > all source files, except the scripts which are used to build the package. In > fact all files which land in the debug package doesn't need to be executable. > done > > By the way, the license checks: > > $ licensecheck -r * | grep GPL > docs/xml2po.py: GPL (v2 or later) (with incorrect FSF address) > > GPL-licensed is only xml2po.py. This is a helper script here, there's no GPL > software which land in the resulting packages. Drop this license declaration > generally. done > > $ licensecheck -r * | grep ISC > tests/DirectExecTest.cpp: ISC > tests/UnicodeHandlingTest.cpp: ISC > tests/C4ValueTest.cpp: ISC > tests/C4StringTableTest.cpp: ISC > > As long as nothing of the test code goes into the resulting binaries, you > can also drop the ISC license. done > > Regarding the CreativeCommons license, I can't find any license declaration > within a file (or even a separate file). Are you sure CreativeCommons is > applicable here? i found this on wiki: http://en.wikipedia.org/wiki/File:OpenClonk_Icon.png that means CC-BY-NC-3.0 correct ? and Clonk Source Code License (ISC) http://www.clonk.de/source.php and Clonk Game Content License http://www.clonk.de/developer.php?lng=en Creative Commons Attribution-NonCommercial (CC BY-NC) http://creativecommons.org/licenses/by-nc/4.0/ which License tag should i use now ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review
