https://bugzilla.redhat.com/show_bug.cgi?id=1186503 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mario.blaettermann@xxxxxxxx | |m Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Alias| |openclonk Flags| |fedora-review? --- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- Some initial comments: -DCMAKE_INSTALL_PREFIX="%{_prefix}" becomes superfluous when you use %cmake instead of the pure "cmake" command. Replace "BuildRequires: hicolor-icon-theme" with "Requires: hicolor-icon-theme". %package data ... Requires: %{name} = %{version}-%{release} Is the data package optional or rather mandatory to run the game? If the latter applies, then the base package has to depend on the main package. In that case you have to add the license file also to the -data package, and licenses/*.txt goes to %licenses anyway. And last but not least, an appdata file would be nice... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review