https://bugzilla.redhat.com/show_bug.cgi?id=1178912 Jan Pokorný <jpokorny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jpokorny@redhat.c | |om) | --- Comment #26 from Jan Pokorný <jpokorny@xxxxxxxxxx> --- Mamoru, sorry for stalling the review, had some other urgencies + meetings piggybacking Devconf.cz conference. I've thought over your "avoiding noarch" reasoning and now it makes sense to me ... apparently I am not an experienced packager but trying to get there :) So my current objections divided into strong and weak ones: Strong ------ 1. It seems unfortunate to split CDBashApplet.{py,sh}. Currently: ./cairo-dock-plug-ins-3.4.0-11.fc21.x86_64.rpm/usr/share/cairo-dock/plug-ins/Dbus/CDBashApplet.sh ./cairo-dock-python3-3.4.0-11.fc21.x86_64.rpm/usr/lib/python3.4/site-packages/CDBashApplet.py while, if I read the code correctly, CDBashApplet.py depends on CDBashApplet.sh being present in the very same directory, i.e., the current arrangement seems a bit futile/illogic. So at the packaging level, these two files should IMHO go together in a single subpackage (you decide which, if any). Wrt. the exact location of these two files it's similar: they should IMHO go to the same directory, perhaps which Python compiled file would depend on (i.e., conditionally) which Python is a default one in particular distribution version (you decide which dir, if any). (again, I apologize for not being able to systematically discover any other similar inter-file dependencies, this was a matter of coincidence, furthermore I am not 100% sure about that) 2. I cannot find a reason why cairo-dock-vala-devel needs to depend on cairo-dock-plug-ins; it already indirectly depends on cairo-dock-plug-ins-common and cairo-dock-core Weak ---- 3. (releated especially to [comment 13]) still, cairo-dock-plug-ins-common deserves to be noarch, it's a terminal in the dependency chain and nothing platform specific in here -- or are you considering future arch-specificity or restructuring the dependencies? - looking at the dependency graph carefully, it might be sort of an optimization (a bit forced, though) if cairo-dock-plug-ins-common depended on cairo-dock-core as there would be no factual change in the dependencies[*], but plenty (9) of Requires lines could be dropped ... certainly, in that case it would have to be arch-specific and %{?_isa} macro used [*] provided that nobody wants to install cairo-dock-plug-ins-common in isolation, which provided that it carries only the licenses, simply won't happen I hope these are good points. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review