[Bug 1079090] Review Request: layla-fonts - A collection of traditional Arabic fonts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1079090



--- Comment #38 from Jonathan Dieter <jdieter@xxxxxxxxx> ---
===== MUST items =====

[x]: Package must own all directories that it creates.

     This is fixed now.

[x]: Each %files section contains %defattr if rpm < 4.4

     Apologies!  This was brought up by fedora-review and I took it at its
word.
     I assume that the %_font_pkg macro uses %defattr.  Either way, feel free
to
     ignore this.

[x]: License field in the package spec file matches the actual license.

     Looks good!

===== EXTRA items =====

[!]: Run repo-font-audit on all fonts in package.

     layla-koufi, layla-boxer and layla-thuluth are missing some glyphs in the
     Arabic block.  This *isn't* a blocker, but if you could keep it in mind
(or
     just tell me that repo-font-audit doesn't know what it's talking about)
that
     would be great.

     Note: full results in attached repo-font-audit.log.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]