[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080411



--- Comment #26 from Karel Volný <kvolny@xxxxxxxxxx> ---
(In reply to Raphael Groner from comment #25)
> Remove these lines and put "Requires: hicolor-icon-theme". The guideline
> says to not own folders from a filesystem package, hicolor-icon-theme owns
> those folders already. This is the common way to do it.

please re-read comments 16-18

the fact that a package owns directories doesn't automatically make it "a
filesystem package" - in fact the guidelines[*] give an example where a package
(gtk-doc) owns a directory (/usr/share/gtk-doc/) and yet the second package
(evolution) _should own_ that directory

[*]
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

give me some official statement that hicolor-icon-theme is an exception both to
naming scheme (it's not *-filesystem) and both that it can include not just
(empty) directories

e.g., the easiest, have this bullet:

"any directories owned by the filesystem, man, or other explicitly created
-filesystem packages"

changed to

"any directories owned by the filesystem, man, hicolor-icon-theme, or other
explicitly created -filesystem packages"

otherwise, formally, I cannot agree with your interpretation of the guidelines,
and personally, I do not like pulling in unnecessary dependencies

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]