[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1080411



--- Comment #25 from Raphael Groner <projects.rg@xxxxxxxx> ---
(In reply to Karel Volný from comment #24)
…
> btw, has anyone taken the hicolor-icon-theme issue anywhere, have I missed
> something?

>From your spec file:
%dir %{_datadir}/icons/hicolor
%dir %{_datadir}/icons/hicolor/*
%dir %{_datadir}/icons/hicolor/*/apps

Remove these lines and put "Requires: hicolor-icon-theme". The guideline says
to not own folders from a filesystem package, hicolor-icon-theme owns those
folders already. This is the common way to do it.

Further, insert the ScriptletSnippets from your comment #5, for proper handling
of icon cache as needed in several desktops.
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]