https://bugzilla.redhat.com/show_bug.cgi?id=1186819 --- Comment #4 from Andrew Niemantsverdriet <andrewniemants@xxxxxxxxx> --- (In reply to Pranav Kant from comment #3) > This is an unofficial review. > > Please correct following issues before a full review of this package. > > Issues: > * Package contains duplicates in %files. > File listed twice: /etc/burp/CA-client > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles > * %clean is not required at all > * There is no need to run rm -rf %{buildroot} at beginning %install. > * Your %files section contains defattr which is not needed anymore. I have corrected the issues listed above and uploaded a new spec file and source rpm. Spec URL: https://fedorapeople.org/~kaptk2/burp.spec SRPM URL: https://fedorapeople.org/~kaptk2/burp-1.3.48-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review