https://bugzilla.redhat.com/show_bug.cgi?id=1186819 --- Comment #3 from Pranav Kant <pranav913@xxxxxxxxx> --- This is an unofficial review. Please correct following issues before a full review of this package. Issues: * Package contains duplicates in %files. File listed twice: /etc/burp/CA-client See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles * %clean is not required at all * There is no need to run rm -rf %{buildroot} at beginning %install. * Your %files section contains defattr which is not needed anymore. Rpmlint output: Checking: burp-1.3.48-1.fc21.x86_64.rpm burp-1.3.48-1.fc21.src.rpm burp.x86_64: W: spelling-error %description -l en_US librsync -> library burp.x86_64: E: executable-marked-as-config-file /etc/burp/summary_script burp.x86_64: E: standard-dir-owned-by-package /usr/share/man/man8 burp.x86_64: E: executable-marked-as-config-file /etc/burp/notify_script burp.x86_64: E: executable-marked-as-config-file /etc/burp/timer_script burp.x86_64: E: executable-marked-as-config-file /etc/burp/ssl_extra_checks_script burp.src: W: spelling-error %description -l en_US librsync -> library 2 packages and 0 specfiles checked; 5 errors, 2 warnings. Source checksums: https://github.com/grke/burp/archive/1.3.48.tar.gz : CHECKSUM(SHA256) this package : 1c45d0b052367595000e64d33eb5d742dbc0e0a9b24bc917a6b4f98b43c0ffdc CHECKSUM(SHA256) upstream package : 1c45d0b052367595000e64d33eb5d742dbc0e0a9b24bc917a6b4f98b43c0ffdc OK -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review