https://bugzilla.redhat.com/show_bug.cgi?id=1182261 --- Comment #31 from Sinny Kumari <ksinny@xxxxxxxxx> --- Thanks Parag and Michael for helping me with understanding minute details of Fedora packaging. In order to do complete Fedora-review, I am starting it with my own package and would like to get feedback if I have done complete review of package correctly. Once I get go ahead I will do complete review of other packages as well and will post review link here for easy reference. Fedora-review of libabigail package ----------------------------------- * Fedora review shows one Failed item as [!]: Uses parallel make %{?_smp_mflags} macro. But, libabigail spec file already uses this macro. * I have done manual review as well. Rest looks good to me. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libabigail-1.0-0.3.20150114git63c81f0.fc21.x86_64.rpm libabigail-devel-1.0-0.3.20150114git63c81f0.fc21.x86_64.rpm libabigail-doc-1.0-0.3.20150114git63c81f0.fc21.x86_64.rpm libabigail-1.0-0.3.20150114git63c81f0.fc21.src.rpm libabigail.x86_64: W: spelling-error %description -l en_US applicatipon -> application, supplication, applicator libabigail.x86_64: W: no-manual-page-for-binary abidiff libabigail.x86_64: W: no-manual-page-for-binary abicompat libabigail.x86_64: W: no-manual-page-for-binary abilint libabigail.x86_64: W: no-manual-page-for-binary abidw libabigail-devel.x86_64: W: only-non-binary-in-usr-lib libabigail-devel.x86_64: W: no-documentation libabigail-doc.x86_64: W: spelling-error Summary(en_US) texinfo -> tinfoil libabigail-doc.x86_64: W: spelling-error Summary(en_US) html -> HTML, ht ml, ht-ml libabigail-doc.x86_64: W: spelling-error %description -l en_US texinfo -> tinfoil libabigail-doc.x86_64: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml libabigail.src: W: spelling-error %description -l en_US abidiff -> abiding libabigail.src: W: spelling-error %description -l en_US abicompat -> compatible libabigail.src: W: spelling-error %description -l en_US abidw -> abide libabigail.src: W: spelling-error %description -l en_US abilint -> ability libabigail.src: W: spelling-error %description -l en_US applicatipon -> application, supplication, applicator libabigail.src: W: invalid-url Source0: libabigail-1.0.tar.gz 4 packages and 0 specfiles checked; 0 errors, 17 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- libabigail-doc (rpmlib, GLIBC filtered): /bin/sh info libabigail (rpmlib, GLIBC filtered): /sbin/ldconfig libabigail.so.0()(64bit) libc.so.6()(64bit) libdw.so.1()(64bit) libdw.so.1(ELFUTILS_0.122)(64bit) libdw.so.1(ELFUTILS_0.126)(64bit) libdw.so.1(ELFUTILS_0.143)(64bit) libdw.so.1(ELFUTILS_0.148)(64bit) libelf.so.1()(64bit) libelf.so.1(ELFUTILS_1.0)(64bit) libelf.so.1(ELFUTILS_1.1.1)(64bit) libelf.so.1(ELFUTILS_1.2)(64bit) libelf.so.1(ELFUTILS_1.5)(64bit) libelf.so.1(ELFUTILS_1.6)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.0)(64bit) libxml2.so.2(LIBXML2_2.5.7)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) rtld(GNU_HASH) libabigail-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libabigail(x86-64) libabigail.so.0()(64bit) pkgconfig(libxml-2.0) Provides -------- libabigail-doc: libabigail-doc libabigail-doc(x86-64) libabigail: libabigail libabigail(x86-64) libabigail.so.0()(64bit) libabigail-devel: libabigail-devel libabigail-devel(x86-64) pkgconfig(libabigail) Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/bin/fedora-review -n libabigail Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review