[Bug 1182261] Review Request: libabigail - Tool for constructing, manipulating, serializing and de-serializing ABI-relevant artifacts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1182261



--- Comment #30 from Michael Schwendt (Fedora Packager Sponsors Group) <bugs.michael@xxxxxxx> ---
Some hints:

* When offering more than one package and/or a few reviews, you give your
potential sponsor(s) more material to examine. That's a good thing. Some
sponsors take over the reviewing of _all_ your initial packages. Some will
watch/observe your activity in bugzilla anyway and may join with additional
comments/guidance.

* Many "new" packagers focus on making a package build on their local system
and then stop there. So far, so good. Fedora's packaging guidelines are complex
and really can be overwhelming. No doubt about that. They also address lots of
issues, which can be considered "minor" only. If someone misses such details,
it doesn't necessarily make a package BAD. However, it bears a risk that a
packager (re)introduces packaging mistakes because of not looking up the
guidelines. On the contrary, the guidelines are not complete either. There are
lots of packaging pitfalls not covered by them.

* Where to start? There's this page, which is like a checklist:

  https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

Read it and try to review *your own* package(s) based on the list of
MUST/SHOULD items.

* The  fedora-review  tool automates several checks, especially some that can
be important, such as checking licensing of source files. It is there to help
you. Concentrate on any real errors it reports, also in the rpmlint section.
Examine any warnings and ask about them, if there are questions:

  https://fedoraproject.org/wiki/Common_Rpmlint_issues

* After approval of a package, it can get much more difficult depending on how
familiar you are with the source code and how much support you get from the
upstream authors. There are packagers, who manage to push a package through the
review process, but who abandon the package as soon as the first problem
reports come in via bugzilla and need activity, such as debugging, patching,
forwarding things upstream.

* And probably most important, you need to know where to search for information
or where to ask for help. A good entry-point in the Wiki for packagers is this:

  https://fedoraproject.org/wiki/Category:Package_Maintainers

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]