[Bug 1144801] Review Request: globus-xio-gridftp-multicast - Globus Toolkit - Globus XIO GridFTP Multicast Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1144801



--- Comment #3 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> ---
(In reply to Nikos Mavrogiannopoulos from comment #2)
> I have only the following three questions:
> 1. A question is what is the reason for the _licensedir checks? Why not
> simply  %license?
> %{!?_licensedir: %doc %{_pkgdocdir}/GLOBUS_LICENSE}
> %{?_licensedir: %license GLOBUS_LICENSE}

The %license directive in the %files section is a new invention that in only
understood by fairly new versions of rpm. If seen by the rpm versions in e.g.
RHEL 5 and 6 it will not work at all. This construct is needed to build for
EPEL 5 and 6.

> 2. There is also no so-version in libglobus_xio_gridftp_multicast_driver.so.
> The plain .so is used only for linking, thus it should be in the -devel
> counterpart. If the .so is so that it can be dlopened by another program then
> note the text, about convincing upstream on using versioned libraries:
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#Shared_Libraries

This is not a library. It is a module loaded dynamically at runtime, i.e. a
plugin. The guideline you refer to explicitly says it does not apply to
plugins:
"In cases where upstream ships unversioned .so library (so this is not needed
for plugins, drivers, etc.), ..."

> 3. You do run rm -rf %{buildroot}, is that for compiling under epel5?

Yes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]