https://bugzilla.redhat.com/show_bug.cgi?id=1144801 Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nmavrogi@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |nmavrogi@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Nikos Mavrogiannopoulos <nmavrogi@xxxxxxxxxx> --- I have only the following three questions: 1. A question is what is the reason for the _licensedir checks? Why not simply %license? %{!?_licensedir: %doc %{_pkgdocdir}/GLOBUS_LICENSE} %{?_licensedir: %license GLOBUS_LICENSE} 2. There is also no so-version in libglobus_xio_gridftp_multicast_driver.so. The plain .so is used only for linking, thus it should be in the -devel counterpart. If the .so is so that it can be dlopened by another program then note the text, about convincing upstream on using versioned libraries: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shared_Libraries 3. You do run rm -rf %{buildroot}, is that for compiling under epel5? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. Note: Test run failed [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Test run failed [x]: Packages must not store files under /srv, /opt or /usr/local Note: Test run failed [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. ===== SHOULD items ===== Generic: [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Test run failed [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: globus-xio-gridftp-multicast-1.5-2.fc21.x86_64.rpm globus-xio-gridftp-multicast-devel-1.5-2.fc21.x86_64.rpm globus-xio-gridftp-multicast-1.5-2.fc21.src.rpm globus-xio-gridftp-multicast.x86_64: E: invalid-soname /usr/lib64/libglobus_xio_gridftp_multicast_driver.so libglobus_xio_gridftp_multicast_driver.so globus-xio-gridftp-multicast-devel.x86_64: W: only-non-binary-in-usr-lib globus-xio-gridftp-multicast-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 1 errors, 2 warnings. Requires -------- globus-xio-gridftp-multicast-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config globus-common-devel(x86-64) globus-ftp-client-devel(x86-64) globus-xio-devel(x86-64) globus-xio-gridftp-multicast(x86-64) pkgconfig(globus-common) pkgconfig(globus-ftp-client) pkgconfig(globus-xio) globus-xio-gridftp-multicast (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libglobus_common.so.0()(64bit) libglobus_common.so.0(GLOBUS_COMMON_14)(64bit) libglobus_ftp_client.so.2()(64bit) libglobus_xio.so.0()(64bit) rtld(GNU_HASH) Provides -------- globus-xio-gridftp-multicast-devel: globus-xio-gridftp-multicast-devel globus-xio-gridftp-multicast-devel(x86-64) pkgconfig(globus-xio-gridftp-multicast) globus-xio-gridftp-multicast: globus-xio-gridftp-multicast globus-xio-gridftp-multicast(x86-64) libglobus_xio_gridftp_multicast_driver.so()(64bit) Unversioned so-files -------------------- globus-xio-gridftp-multicast: /usr/lib64/libglobus_xio_gridftp_multicast_driver.so Source checksums ---------------- http://www.globus.org/ftppub/gt6/packages/globus_xio_gridftp_multicast-1.5.tar.gz : CHECKSUM(SHA256) this package : 1d345443d35a763bd2b2da38fd3bb3222b4ff32ce653df1be15f29f9f1571c71 CHECKSUM(SHA256) upstream package : 1d345443d35a763bd2b2da38fd3bb3222b4ff32ce653df1be15f29f9f1571c71 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -n globus-xio-gridftp-multicast Buildroot used: fedora-21-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review