[Bug 1178934] Review Request: perl-Exporter-Tidy - Another way of exporting symbols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1178934



--- Comment #2 from Petr Šabata <psabata@xxxxxxxxxx> ---
(In reply to Petr Pisar from comment #1)
> TODO: Insert some statement into the description that this is about Perl.
> E.g. "This Perl module serves".

Nack; I think this is rather obvious from the package name.

> TODO: Remove bundled Test::More and Test::Builder from t/lib to use system
> ones when running tests.

Nack; I usually keep the bundled modules used for build only and will keep
these too.  However, I removed the erroneus Test::More BR as pointed out
further below.

> FIX: The README states "public domain", but the Tidy.pm stats:
> 
> > Pick your favourite OSI approved license :)
> > http://www.opensource.org/licenses/alphabetical
> 
> These two contradicts (Public Domain is not on the list).
> 
> You need to add the Tidy.pm's license to the License tag. Either list all
> OSI-approved licenses, or get a new Tidy.pm without the statement from the
> author.

Hmm, listing all the licenses would still conflict with the Public domain
statement.  I've emailed the author asking for clarification.

> FIX: Do not build-require Test::More, or remove the bundled module and do
> not build-require its dependencies.

Removed.

I'll post an updated package once I receive some response from upstream
regarding the licensing terms.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]