https://bugzilla.redhat.com/show_bug.cgi?id=1178934 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are usable. Ok. Source archive is original (SHA-256: 27734cb4972921824d3cc98428628e81887efa6e97eb4c0cb628a9225fb7f160). Ok. Summary verified from Tidy.pm. Ok. Description verified from Tidy.pm. Ok. TODO: Insert some statement into the description that this is about Perl. E.g. "This Perl module serves". TODO: Remove bundled Test::More and Test::Builder from t/lib to use system ones when running tests. FIX: The README states "public domain", but the Tidy.pm stats: > Pick your favourite OSI approved license :) > http://www.opensource.org/licenses/alphabetical These two contradicts (Public Domain is not on the list). You need to add the Tidy.pm's license to the License tag. Either list all OSI-approved licenses, or get a new Tidy.pm without the statement from the author. No XS code, noarch BuildArch is Ok. FIX: Do not build-require Test::More, or remove the bundled module and do not build-require its dependencies. All tests pass. Ok. $ rpmlint perl-Exporter-Tidy.spec ../SRPMS/perl-Exporter-Tidy-0.07-1.fc22.src.rpm ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm perl-Exporter-Tidy.src: W: spelling-error %description -l en_US subclassed -> sub classed, sub-classed, subclass ed perl-Exporter-Tidy.src: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace perl-Exporter-Tidy.noarch: W: spelling-error %description -l en_US subclassed -> sub classed, sub-classed, subclass ed perl-Exporter-Tidy.noarch: W: spelling-error %description -l en_US namespace -> name space, name-space, names pace 2 packages and 1 specfiles checked; 0 errors, 4 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm drwxr-xr-x 2 root root 0 Jan 6 07:11 /usr/share/doc/perl-Exporter-Tidy -rw-r--r-- 1 root root 308 Sep 14 2007 /usr/share/doc/perl-Exporter-Tidy/Changes -rw-r--r-- 1 root root 4953 Mar 30 2003 /usr/share/doc/perl-Exporter-Tidy/README -rw-r--r-- 1 root root 3134 Jan 6 07:11 /usr/share/man/man3/Exporter::Tidy.3pm.gz drwxr-xr-x 2 root root 0 Jan 6 07:11 /usr/share/perl5/vendor_perl/Exporter -rw-r--r-- 1 root root 6426 Sep 14 2007 /usr/share/perl5/vendor_perl/Exporter/Tidy.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.20.1) 1 perl(Carp) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm | sort -f | uniq -c 1 perl(Exporter::Tidy) = 0.07 1 perl-Exporter-Tidy = 0.07-1.fc22 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Exporter-Tidy-0.07-1.fc22.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8537319). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixinf `TODO' items, and provide a new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review