https://bugzilla.redhat.com/show_bug.cgi?id=1177009 Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |mario.blaettermann@xxxxxxxx | |m Flags| |fedora-review? --- Comment #8 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> --- (In reply to Steve Linabery from comment #7) > On a different point, the most compelling reason not to bother with python3 > right now (apart from missing python3-oslo-sphinx) is that the package that > will Requires python-tempest-lib (openstack-tempest) has no python3 package > and is unlikely to have one in the near future. OK, nobody needs the python3 version for now and in the foreseeable future. And we are still far from getting rid of python2 in Fedora. So I assume it is OK to don't build the python3 version. Here's a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8532140 $ rpmlint -i -v * python-tempest-lib.noarch: I: checking python-tempest-lib.noarch: I: checking-url http://www.openstack.org/ (timeout 10 seconds) python-tempest-lib.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-tempest-lib/html/_static/jquery.js This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. python-tempest-lib.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/tempest_lib/cmd/subunit_trace.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. python-tempest-lib.noarch: W: no-manual-page-for-binary subunit-trace Each executable in standard binary directories should have a man page. python-tempest-lib.src: I: checking python-tempest-lib.src: I: checking-url http://www.openstack.org/ (timeout 10 seconds) python-tempest-lib.src: I: checking-url https://pypi.python.org/packages/source/t/tempest-lib/tempest-lib-0.0.2.tar.gz (timeout 10 seconds) python-tempest-lib.spec: I: checking python-tempest-lib.spec: I: checking-url https://pypi.python.org/packages/source/t/tempest-lib/tempest-lib-0.0.2.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 1 errors, 2 warnings. The missing man page is not up to you to fix, but you could file this as an upstream bug. Remove the shebang from /usr/lib/python2.7/site-packages/tempest_lib/cmd/subunit_trace.py, scripts in %{python2_sitelib} doesn't need a shebang. As already mentioned by Miroslav Suchý, please use the %license macro: http://fedoraproject.org/wiki/Changes/Use_license_macro_in_RPMs_for_packages_in_Cloud_Image I take this for a full review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review