Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-decoratortools - Use class and function decorators -- even in Python 2.3 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238932 toshio@xxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |toshio@xxxxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From toshio@xxxxxxxxxxxxxxx 2007-05-08 19:41 EST ------- Approved MD5Sums: 20789f305884614948f191ce7458d377 python-decoratortools-1.4-2.fc7.src.rpm Good: * rpmlint output: W: python-decoratortools invalid-license PSF or ZPL W: python-decoratortools invalid-license PSF or ZPL PSF is python software foundation license and ZPL is Zope Public License, both valid licenses for Fedora. * Package and spec follow the naming guidelines for Python Modules. * License filed matches the license of the package and is approved for Fedora. (Listed in the PKG-INFO file) * Source file matches upstream. * Builds to a noarch package on x86_64 FC6. * Successfully builds in mock. * No locale files. * Not a dynamic library. * Not relocatable. * Package owns all directories that it creates. Note that the %{python_sitelib}/peak directory structure is a namespace directory. Contrary to what I said earlier on IRC, this appears to be covered by this: http://fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership * No duplicate files. * Proper %clean. * Consistent use of macros. * Not a GUI app * Works for the simple examples included in the documentation. Minor: * License text is not included in the upstream package. Might want to ping upstream about including that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review