https://bugzilla.redhat.com/show_bug.cgi?id=1103414 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tchollingsworth@g | |mail.com) | --- Comment #4 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to Dominik 'Rathann' Mierzejewski from comment #3) > A quick fedora-review run reveals one issue: > > Issues: > ======= > - Package does not contain duplicates in %files. Fixed. I guess the %ghost files caused this. I also fixed a wrong-end-of-line-encoding rpmlint warning I hadn't noticed before. > Licence seems ok (MIT), but it's not specified in any of the source files > (not a blocker). Yeah that's unfortunately pretty common. :-( > mock build.log shows some warnings during %build: > Registering "grunt-git-authors" local Npm module tasks. > >> Local Npm module "grunt-git-authors" not found. Is it installed? > > and similar for grunt-contrib-watch, grunt-contrib-jshint and > grunt-contrib-qunit. > > Are these anything to worry about? No. grunt-git-authors is only needed for releasing (changelog generation). grunt-contrib-watch is for developers only: if you execute `grunt watch` it places inotify watches on the various projects and rebuilds everything if one changes. grunt-contrib-qunit is the only thing we _should_ have, as it's needed for running the tests. But, as the "q" in the name hints, it runs tests in a QtWebKit frame and thus won't work well in koji. :-( Note that grunt only displays these warnings because I request verbose output via `-v` in the build. I guess I could turn that off to avoid confusing messages, but I do find it convenient to have the extra output always there on the offchance it is needed when a problem arises in some future update. > I will try to do a more complete review during the Christmas break. Thanks for the review so far! I hope you and your family had a wonderful holiday. -- Spec: https://patches.fedorapeople.org/jquery/js-jquery-migrate.spec SRPM: https://patches.fedorapeople.org/jquery/js-jquery-migrate-1.2.1-4.fc20.src.rpm * Mon Dec 29 2014 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> - 1.2.1-4 - correct duplicate in files list - use correct end-of-line encoding in README.md file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review