https://bugzilla.redhat.com/show_bug.cgi?id=1103414 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tchollingsworth@xxxxxxxxx Flags| |needinfo?(tchollingsworth@g | |mail.com) --- Comment #3 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- A quick fedora-review run reveals one issue: Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/javascript/jquery- migrate/jquery+migrate.js See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles I think you need to specify %dir before: %{_jsdir}/jquery-migrate and list the files inside one by one: %{_jsdir}/jquery-migrate/jquery-migrate.js %{_jsdir}/jquery-migrate/jquery-migrate.min.js Licence seems ok (MIT), but it's not specified in any of the source files (not a blocker). mock build.log shows some warnings during %build: Registering "grunt-git-authors" local Npm module tasks. >> Local Npm module "grunt-git-authors" not found. Is it installed? and similar for grunt-contrib-watch, grunt-contrib-jshint and grunt-contrib-qunit. Are these anything to worry about? I will try to do a more complete review during the Christmas break. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review